Add market data demo and code review#48
Open
joeymaza wants to merge 2 commits intoed-donner:mainfrom
Open
Conversation
Comprehensive review of backend/app/market/ covering all 8 modules and 73 tests. Documents findings on SSE test coverage gap, stream router singleton bug, and minor interface asymmetries. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ta source Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backend/market_demo.py— a lightweight streaming CLI demo that uses thecreate_market_data_sourcefactory, so it works with both the GBM simulator (default) and the Massive API ifMASSIVE_API_KEYis set. Prints ANSI-colored price updates per tick and a session summary on exit.planning/MARKET_DATA_REVIEW.md— a code review of the market data subsystem.Test plan
/.sprite/bin/python3 market_demo.pyfrombackend/and verify 10 tickers stream for 30s with green/red/dim color coding🤖 Generated with Claude Code